Default initializers on required parameters#4022
Merged
Merged
Conversation
Member
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
Jul 28, 2015
Default initializers on required parameters
Member
|
@JsonFreeman do we have any issue tracking the associated spec change? :) |
Contributor
Author
|
Oh man, I keep forgetting. And you always catch it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3604.
This PR relaxes our rules to allow default initializers to be present on required parameters as well as optional parameters. To be concrete, we allow default initializers on all parameters. To be considered an optional parameter, the parameter must have a question mark, or it must have an initializer and not be followed by a required parameter anywhere in the rest of the signature.
For example, in the following signatures,
ais optional:But in the following signature,
ais not optional:One thing to note is that an optional parameter corresponds to an argument slot that is allowed to be missing. The default initializers for required parameters kick in when undefined is passed, but the argument is not allowed to be omitted entirely.
This should not be a breaking change.