Skip to content

Revert to including only open files in partial semantic server mode#40026

Merged
DanielRosenwasser merged 1 commit intomasterfrom
openFileOnly
Aug 13, 2020
Merged

Revert to including only open files in partial semantic server mode#40026
DanielRosenwasser merged 1 commit intomasterfrom
openFileOnly

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Aug 13, 2020

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 13, 2020
@sheetalkamat sheetalkamat requested review from DanielRosenwasser, amcasey and andrewbranch and removed request for andrewbranch August 13, 2020 00:23
@sheetalkamat
Copy link
Member Author

sheetalkamat commented Aug 13, 2020

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020 •
edited
Loading

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.0 on this PR at 8f442ba. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Aug 13, 2020
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020

Hey @sheetalkamat, I've opened #40028 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 13, 2020
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#40026 into release-4.0
7e4ec9e 
Component commits:
8f442ba Revert to including only open files in partial semantic server mode
amcasey
amcasey approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code in detail, but I'm totally on board with the concept.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 13, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 8f442ba. You can monitor the build here.

DanielRosenwasser
DanielRosenwasser approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naively, looks good. I'll try this out locally tonight and merge the 4.0 PR if appropriate.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/82128/artifacts?artifactName=tgz&fileId=99F1C6B75D4971FA0FC0D61D468B548EBFA9CF777E23EA64619C9D20DAF7791202&fileName=/typescript-4.1.0-insiders.20200813.tgz"
    }
}

and then running npm install.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 13, 2020

Looks good to me locally after some finagling.

DanielRosenwasser pushed a commit that referenced this pull request Aug 13, 2020
@sheetalkamat
Cherry-pick PR #40026 into release-4.0 (#40028)
a192551 
Component commits:
8f442ba Revert to including only open files in partial semantic server mode

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@DanielRosenwasser DanielRosenwasser merged commit 03d946d into master Aug 13, 2020
@sheetalkamat sheetalkamat deleted the openFileOnly branch August 13, 2020 06:15
@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 3, 2021
Open
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

+1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sheetalkamat @typescript-bot @DanielRosenwasser @amcasey