Skip to content

Handle the fact that noResolveResolution resolution is reused#39889

Merged
sheetalkamat merged 1 commit into
masterfrom
watchFailedLookupPartialSemantic
Aug 4, 2020
Merged

Handle the fact that noResolveResolution resolution is reused#39889
sheetalkamat merged 1 commit into
masterfrom
watchFailedLookupPartialSemantic

Conversation

@sheetalkamat

Copy link
Copy Markdown
Member

Fixes #39795

@DanielRosenwasser

Copy link
Copy Markdown
Member

@typescript-bot cherry-pick this to release-4.0

@typescript-bot

typescript-bot commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at c3ac7fa. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey @DanielRosenwasser, I've opened #39890 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 3, 2020
Component commits:
c3ac7fa Handle the fact that noResolveResolution resolution is reused Fixes microsoft#39795
Comment thread src/compiler/resolutionCache.ts Outdated
DanielRosenwasser pushed a commit that referenced this pull request Aug 4, 2020
Component commits:
c3ac7fa Handle the fact that noResolveResolution resolution is reused Fixes #39795

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@sheetalkamat sheetalkamat force-pushed the watchFailedLookupPartialSemantic branch from c3ac7fa to 9d43830 Compare August 4, 2020 18:29
@sheetalkamat sheetalkamat merged commit bcccae2 into master Aug 4, 2020
@sheetalkamat sheetalkamat deleted the watchFailedLookupPartialSemantic branch August 4, 2020 20:33
@DanielRosenwasser

Copy link
Copy Markdown
Member

@typescript-bot cherry-pick this to release-4.0 and LKG

@typescript-bot

typescript-bot commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 9d43830. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser restored the watchFailedLookupPartialSemantic branch August 4, 2020 22:46
@typescript-bot

Copy link
Copy Markdown
Contributor

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

@DanielRosenwasser DanielRosenwasser deleted the watchFailedLookupPartialSemantic branch August 4, 2020 23:32
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS Server fatal error: Debug Failure. False expression.

4 participants