Remove non null assertion on oldSourceFile.resolvedModules#38984
Merged
sheetalkamat merged 1 commit intomasterfrom Jun 9, 2020
Merged
Remove non null assertion on oldSourceFile.resolvedModules#38984sheetalkamat merged 1 commit intomasterfrom
sheetalkamat merged 1 commit intomasterfrom
Conversation
weswigham
approved these changes
Jun 8, 2020
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 10, 2020
* upstream/master: (36 commits) Update baselines (microsoft#39000) Make isEntityNameVisible duplicate the node builder logic to always consider type parameters as visible if they are the resolution result (microsoft#38921) Schedule failed lookup updates (microsoft#38560) Remove non null assertion on oldSourceFile.resolvedModules (microsoft#38984) use blocklist instead of blacklist (microsoft#38988) LEGO: check in for master to temporary branch. Deprecate reloadFs so the tests are more clear in what they are achieving and its easier to track changed behaviour (microsoft#38954) LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Make `hasCorrectArity` handle tuples properly fix error when use spread arguments twice fix(38081): allow transforming object binding to named imports Accept baseline fix names Fix type and simplify code accept new baseline fix rebase conflict add missing semi Add more check fix mission baseline ...
Member
|
@typescript-bot cherry-pick this to release-3.9 |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jul 7, 2020
Component commits: a06e1c5 Remove non null assertion on oldSourceFile.resolvedModules Fixes microsoft#37938
Collaborator
|
Hey @RyanCavanaugh, I've opened #39480 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37938
As mentioned #37938 (comment) dont see why this should fail so dont have test case but since fix is trivial here it is