Include unknown in spread prop override check - #38577
Merged
Wesley Wigham (weswigham) merged 1 commit intoMay 14, 2020
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Nathan Shively-Sanders (sandersn)
May 14, 2020 18:54
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
May 14, 2020
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9 |
Contributor
|
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Ryan Cavanaugh (@RyanCavanaugh), I've opened #38581 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 14, 2020
Component commits: e5bccaf Include unknown in spread prop override check
Wesley Wigham (weswigham)
deleted the
include-unknown-in-spread-override-check
branch
May 14, 2020 21:36
AllenLee (cangSDARM)
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 15, 2020
* upstream/master: Include unknown in spread prop override check (microsoft#38577) Fix (cosmetic) typos in checker.ts comments
Ryan Delaney (rrdelaney)
pushed a commit
to rrdelaney/TypeScript
that referenced
this pull request
May 18, 2020
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
May 27, 2020
I was hitting a bug in 3.9.2 with the breadcrumbs CL [1] that is fixed in 3.9.3 via this PR [2]. (I've verified locally that it is fixed). [1]: microsoft/TypeScript#38535 [2]: microsoft/TypeScript#38577 DISABLE_THIRD_PARTY_CHECK=typescript update Change-Id: Ia874e5936a5bbf0bf26f751ab746976f71910f25 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218013 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
BinaryAge Bot (babot)
pushed a commit
to binaryage/dirac
that referenced
this pull request
May 28, 2020
I was hitting a bug in 3.9.2 with the breadcrumbs CL [1] that is fixed in 3.9.3 via this PR [2]. (I've verified locally that it is fixed). [1]: microsoft/TypeScript#38535 [2]: microsoft/TypeScript#38577 DISABLE_THIRD_PARTY_CHECK=typescript update Change-Id: Ia874e5936a5bbf0bf26f751ab746976f71910f25 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218013 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38535