Skip to content

regression(38485): Unable to specify rawText when programmatically creating tagged template literals - #38500

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:masterfrom
a-tarasyuk:bug/38485
May 19, 2020
Merged

regression(38485): Unable to specify rawText when programmatically creating tagged template literals#38500
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
microsoft:masterfrom
a-tarasyuk:bug/38485

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #38485

@a-tarasyuk

Copy link
Copy Markdown
Contributor Author

@DanielRosenwasser

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9

@typescript-bot

TypeScript Bot (typescript-bot) commented May 12, 2020

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-3.9 on this PR at ee3f2ce. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #38506 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request May 12, 2020
Component commits:
ee3f2ce regression(38485): allow using rawText property in processing a tagged template

@Kingwl Wenlu Wang (Kingwl) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DanielRosenwasser

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented May 14, 2020

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at ee3f2ce. You can monitor the build here.

@DanielRosenwasser

Copy link
Copy Markdown
Member

Pete Bacon Darwin (@petebacondarwin) a build should be available in a bit - can you verify that it works for you?

@petebacondarwin

Copy link
Copy Markdown
Contributor

Will do. Thanks!

@typescript-bot

TypeScript Bot (typescript-bot) commented May 14, 2020

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73938/artifacts?artifactName=tgz&fileId=448F72D04EC0F5F692CE5D20138BF654FD76224192855005E3050150AD16EDFC02&fileName=/typescript-4.0.0-insiders.20200514.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@petebacondarwin

Copy link
Copy Markdown
Contributor

Testing now

@petebacondarwin

Copy link
Copy Markdown
Contributor

That works for me! Thanks for dealing with this so quickly.

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 46f100f into microsoft:master May 19, 2020
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request May 19, 2020
🤖 Pick PR #38500 (regression(38485): Unable to specif...) into release-3.9
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3.9.1-rc regression: Unable to specify rawText when programmatically creating tagged template literals

6 participants