🤖 User test baselines have changed for refs/heads/master#38405
Merged
sandersn merged 1 commit intomicrosoft:masterfrom May 11, 2020
Merged
🤖 User test baselines have changed for refs/heads/master#38405sandersn merged 1 commit intomicrosoft:masterfrom
sandersn merged 1 commit intomicrosoft:masterfrom
Conversation
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
2cc26f4 to
7418b89
Compare
Closed
typescript-bot
force-pushed
the
user-baseline-updates
branch
7 times, most recently
from
3cb583f to
b2edb1e
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
b2edb1e to
a23eb4b
Compare
sandersn
approved these changes
May 11, 2020
| @@ -0,0 +1,18 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/eventemitter3/index.d.ts(22,13): error TS2344: Type 'T[K]' does not satisfy the constraint 'any[] | ((...args: any[]) => void)'. | |||
Member
There was a problem hiding this comment.
Error is different Monday morning than Friday afternoon, and eventemitter3 has published 4.0.1-.3 in the last 24 hours, so I think they're trying to fix type errors manually over there.
Member
There was a problem hiding this comment.
"Better TypeScript type definitions": primus/eventemitter3#217
They will get it figured out eventually I guess.
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 12, 2020
* upstream/master: (54 commits) LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Fix for jsdoc modifiers on constructor params (microsoft#38403) Improve assert message in binder (microsoft#38270) fix broken regex on "src/services/completions.ts#getCompletionData" (microsoft#37546) report error for duplicate @type declaration (microsoft#38340) fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (microsoft#38107) Update user baselines (microsoft#38472) Update user baselines (microsoft#38405) Changed template strings to emit void 0 instead of undefined (microsoft#38430) Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (microsoft#38368) LEGO: check in for master to temporary branch. Make isDynamicFileName available publicly (microsoft#38269) LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Exclude arrays and tuples from full intersection property check (microsoft#38395) Fix crash caused by assertion with evolving array type (microsoft#38398) Update user baselines (microsoft#38128) LEGO: check in for master to temporary branch. moveToNewFile: handle namespace imports too ... # Conflicts: # src/compiler/types.ts # src/compiler/utilities.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript