Skip to content

Allow modifier on class member for classDeclaration/classExpression inside function#3772

Merged
yuit merged 4 commits into
masterfrom
allowModifier
Jul 8, 2015
Merged

Allow modifier on class member for classDeclaration/classExpression inside function#3772
yuit merged 4 commits into
masterfrom
allowModifier

Conversation

@yuit

@yuit yuit commented Jul 7, 2015

Copy link
Copy Markdown
Contributor

Fix Issue #3703

Comment thread src/compiler/checker.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this name as well

@mhegazy

mhegazy commented Jul 8, 2015

Copy link
Copy Markdown
Contributor

👍

Comment thread src/compiler/checker.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the comment up or remove it altogether

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

yuit added a commit that referenced this pull request Jul 8, 2015
Allow modifier on class member for classDeclaration/classExpression inside function
@yuit yuit merged commit 42bff6b into master Jul 8, 2015
@yuit yuit deleted the allowModifier branch July 8, 2015 21:34
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants