Add property URL in Window interface#3741
Closed
xtuc wants to merge 1 commit intomicrosoft:masterfrom
xtuc:master
Closed
Add property URL in Window interface#3741xtuc wants to merge 1 commit intomicrosoft:masterfrom xtuc:master
xtuc wants to merge 1 commit intomicrosoft:masterfrom
xtuc:master
Conversation
|
Hi @xtuc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Member
|
Hey @xtuc thanks for the PR. A few things to note.
@mhegazy and @zhengbli might have some useful input on this. Additionally, I notice that |
Author
|
Ok, sorry I did not notice. I'll let you make the necesary changes because I do not know enough about the language. |
Contributor
|
@zhengbli can you take a look. |
Contributor
|
We need an issue to track this. |
Author
|
I created the issue: #3753 |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error TS2339: Property 'URL' does not exist on type 'Window'.