feat(37092): Improve error when default-importing from a module that export *s from a module with a default export#37212
Conversation
a5a0169 to
645a505
Compare
export *s from a module with a default export
|
Two thoughts:
|
@andrewbranch Thanks for your feedback 👍. Which node do I need to use to add related info? |
|
I guess I’d attach it to the first one whose target has a default export. |
|
@andrewbranch That makes it hard during incremental editing/diagnostics since then order of the checking would guide the diagnostic position ? |
|
I could be wrong, but I don’t think that will be the case. |
645a505 to
626df10
Compare
andrewbranch
left a comment
There was a problem hiding this comment.
Nice! I think this looks great.
Fixes #37092