Preserve arity for preserving js optional parameters#37173
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Mar 4, 2020
Merged
Preserve arity for preserving js optional parameters#37173weswigham merged 1 commit intomicrosoft:masterfrom
weswigham merged 1 commit intomicrosoft:masterfrom
Conversation
andrewbranch
approved these changes
Mar 2, 2020
Member
|
I believe this property also causes differences from TS when choosing overloads too. I'll need to read the change to see whether it might fix those too. |
sandersn
approved these changes
Mar 3, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Let me track down the overload bug so you can check whether it fixes that too. I think it probably will.
Member
|
With small repro: /** @param {{
(fn: (a: number) => void): number;
(fn: (a: number, b: number) => void): string
}} id */
export function test(id) {
/** @type {string} */
var val = id((a, b) => a + b);
} |
Member
|
The problems that my simple fix at #35153 had shows that we should look at webpack (and maybe some others?) before merging to see if they break with this. |
Member
Author
It does not~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36507
For relationship checking, we consider untyped signatures from js as only having 0 required arguments; however we also use that minimum argument count for calculating weather an initialized optional parameter is optional or not. In the later case, we would like that "js signatures have 0 required arguments" rule to not apply, so we can actually recover what parameters are optional.