Hoist initial assignment to exported names in cjs to they are not blocked by bindings made by __exportStar#37093
Merged
weswigham merged 4 commits intomicrosoft:masterfrom Feb 28, 2020
Conversation
…cked by bindings made by __exportStar
ece0b05 to
44bbf14
Compare
rbuckton
approved these changes
Feb 28, 2020
Contributor
rbuckton
left a comment
There was a problem hiding this comment.
May need to discuss in design meeting.
|
Missed the case of exported namespace (export * as foo from 'foo'). |
|
Curious, this violates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this because now that
__createBindingis used by__exportStarto create live-updating getters, if you had input likewe'd output
the assignment will throw because the
__exportStarmade a getter which can't be overridden with a simple assignment. By emittingwe prevent
__exportStarfrom overwritingnameFromModwith a getter (so the assignment succeeds).This also neatly ensures all export names are available to reexport when resolving within a circular module graph.