Grammar error on export type * - #37064
Conversation
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.8 |
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into |
|
Hey Daniel Rosenwasser (@DanielRosenwasser), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.8 manually. |
|
Did I mess that up by merging it? TypeScript Bot (@typescript-bot) cherry-pick this into release-3.8 |
|
Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into |
|
Hey Andrew Branch (@andrewbranch), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.8 manually. |
* Fix renaming an ExportSpecifier name when propertyName is present (#36790) * Fix renaming exportSpecifier name when propertyName is present * Add baseline test for name without propertyName too * Set correct pos for NamespaceExport (#36794) * Set correct pos for NamespaceExport * Update tests * Cherry-pick PR #37064 into release-3.8
4 participants
Fixes #36966
The first commit added the missing calls to
markSymbolOfAliasDeclarationIfTypeOnlyso as to recognizeexport type *forms as type-only while simultaneously disallowing it with a grammar error. Mostly I was curious how close we were to supportingexport type *, and it appears that it’s only a couple extra lines. Afterwards, I reverted the extra calls because it created two errors where one would suffice.