Disable declaration emit for json files - #36066
Merged
Merged
Conversation
Sheetal Nandi (sheetalkamat)
requested review from
Daniel Rosenwasser (DanielRosenwasser),
Ryan Cavanaugh (RyanCavanaugh),
Andrew Casey (amcasey),
Andrew Branch (andrewbranch),
Eli Barzilay (elibarzilay),
Orta Therox (orta),
Ron Buckton (rbuckton),
Nathan Shively-Sanders (sandersn) and
Wesley Wigham (weswigham)
January 8, 2020 00:44
Sheetal Nandi (sheetalkamat)
force-pushed
the
disableJsonDts
branch
from
January 8, 2020 02:04
f7947e0 to
0c4d161
Compare
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.7 |
Contributor
|
Hey Sheetal Nandi (@sheetalkamat), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
Member
|
#34962 ? |
Member
|
Wesley Wigham (@weswigham) we decided against adding a commandline flag at this point; will revive that if we get indicative user feedback |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.