🤖 User test baselines have changed for refs/heads/master#36046
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Jan 9, 2020
Merged
Conversation
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20200002-refs/heads/master
branch
3 times, most recently
from
c87b6d7 to
55e5dd8
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200002-refs/heads/master
branch
from
55e5dd8 to
03359d5
Compare
Member
|
I'll take a look. |
sandersn
reviewed
Jan 8, 2020
| node_modules/lodash/_baseClone.js(91,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(92,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(93,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(114,18): error TS2554: Expected 0 arguments, but got 1. |
Member
There was a problem hiding this comment.
The type of function expressions in conditional expressions has changed. Might be ones that are initialisers of variable decls with jsdoc, not sure yet.
Member
There was a problem hiding this comment.
Here's a repro. I guess we changed our rules for unioning signatures recently.
var noop = () => { };
/**
* @returns {void}
*/
var createSet = !!false ? noop : function(values) {
};
createSet(1) // error before, fine now
sandersn
requested changes
Jan 9, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Let's hold the change until I figure out which commit caused it. I'm not sure it's wrong, just unexpected to me.
| node_modules/lodash/_baseClone.js(91,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(92,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(93,16): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. | ||
| node_modules/lodash/_baseClone.js(114,18): error TS2554: Expected 0 arguments, but got 1. |
Member
There was a problem hiding this comment.
Here's a repro. I guess we changed our rules for unioning signatures recently.
var noop = () => { };
/**
* @returns {void}
*/
var createSet = !!false ? noop : function(values) {
};
createSet(1) // error before, fine now
Member
|
It is #35659; only seems to affect JS signatures. |
sandersn
approved these changes
Jan 9, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Talked to Anders and the new behaviour is fine; the old behaviour was random based on which function came first in the source file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript