Fixes broken emit with useDefineForClassFields + private field#35898
Merged
sandersn merged 2 commits intomicrosoft:masterfrom Jan 9, 2020
Merged
Fixes broken emit with useDefineForClassFields + private field#35898sandersn merged 2 commits intomicrosoft:masterfrom
sandersn merged 2 commits intomicrosoft:masterfrom
Conversation
|
|
ajafff
reviewed
Dec 29, 2019
ajafff
approved these changes
Dec 29, 2019
sandersn
approved these changes
Jan 9, 2020
Member
|
Thanks for the fix @hikarinotomadoi ! |
Kingwl
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Mar 4, 2020
…soft#35898) * Fixes broken emit with useDefineForClassFields + private field * use simpler function for condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for whether the class property is originated from a parameter.
Fixes #35590