Skip to content

Improve Session interface for extensibility#3543

Merged
hoanhtien merged 1 commit into
microsoft:masterfrom
weswigham:lssl-interface-improvement
Jul 13, 2015
Merged

Improve Session interface for extensibility#3543
hoanhtien merged 1 commit into
microsoft:masterfrom
weswigham:lssl-interface-improvement

Conversation

@weswigham

@weswigham weswigham commented Jun 17, 2015

Copy link
Copy Markdown
Member

Following the discussion on #3513. However, I have opted to complete my ideas in this regard for the purposes of discussion, and have entirely factored out the old massive case statement and replaced it with a map.

@msftclas

msftclas commented Jun 17, 2015

Copy link
Copy Markdown

Hi @weswigham, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Wesley Wigham). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@weswigham weswigham mentioned this pull request Jun 17, 2015
Closed
@mhegazy

mhegazy commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

@weswigham can you work with @zhengbli and @billti to verify performance. we have found the dispatcher loop to be very sensitive to refactoring, causing some major perf regressions.

@weswigham weswigham force-pushed the lssl-interface-improvement branch from 7076d76 to d1a2ae5 Compare June 19, 2015 19:44
@zhengbli

zhengbli commented Jun 19, 2015

Copy link
Copy Markdown

It seems what he did was moving the callbacks from the switch case statements to a map; after trying it out I have similar performance with sublime text. So LGTM 👍

@weswigham

weswigham commented Jul 6, 2015

Copy link
Copy Markdown
Member Author

Is there any other work that needs to be done for this PR?

hoanhtien added a commit that referenced this pull request Jul 13, 2015
@hoanhtien
Merge pull request #3543 from weswigham/lssl-interface-improvement
2a9ab73 
Improve Session interface for extensibility
@hoanhtien hoanhtien merged commit 2a9ab73 into microsoft:master Jul 13, 2015
@weswigham weswigham deleted the lssl-interface-improvement branch August 17, 2017 23:02
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weswigham @msftclas @mhegazy @zhengbli @hoanhtien