Skip to content

Add build target for packaging tsserver as a library#3542

Merged
mhegazy merged 4 commits into
microsoft:masterfrom
weswigham:jake-lssl
Jun 18, 2015
Merged

Add build target for packaging tsserver as a library#3542
mhegazy merged 4 commits into
microsoft:masterfrom
weswigham:jake-lssl

Conversation

@weswigham

Copy link
Copy Markdown
Member

Following the discussion on #3513. this is the first half of the proposed changes - only those required to package the service as a library, combined with feedback from the same PR.

@msftclas

Copy link
Copy Markdown

Hi @weswigham, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Wesley Wigham). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Comment thread src/server/editorServices.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ServerHost

@mhegazy

mhegazy commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

thanks. looks good. 2 small comments and we are ready to go.

@weswigham

Copy link
Copy Markdown
Member Author

Got it.

@mhegazy

mhegazy commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

thanks!

mhegazy added a commit that referenced this pull request Jun 18, 2015
Add build target for packaging tsserver as a library
@mhegazy mhegazy merged commit 7361d68 into microsoft:master Jun 18, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants