Removed some trailing comma's causing cscript to fail#354
Closed
DickvdBrink wants to merge 1 commit intomicrosoft:masterfrom
Closed
Removed some trailing comma's causing cscript to fail#354DickvdBrink wants to merge 1 commit intomicrosoft:masterfrom
DickvdBrink wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
This is fixed in #273. I do not think we need this any more. |
Member
|
I don't see scanner and syntaxFacts touched in #273 though |
Contributor
|
Sorry, did not mean the trailing commas, meant that they should not break Cscript. #273 ensured that we are not emitting them in ES3. |
Contributor
Author
|
Ah @mhegazy, you might be right! Missed the commit that it was fixed in the emitted output, sorry about that. |
Contributor
|
thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some trailing comma's
edit: this doesn't cause any real issues as the trailing comma isn't (always??) emitted but I guess it is also coding style