Scan less during classification.#3530
Conversation
There was a problem hiding this comment.
Misleading name; there are no TextSpans given here.
There was a problem hiding this comment.
"numbers do not belong in API names", I will make sure i put that on my tombstone :D
There was a problem hiding this comment.
Sure. I'm open to other names.
|
do you have some classification perf numbers on before and after the change? |
|
Yes. This drops syntactic classification to about a 3rd of the original cost. For something like Checker.ts we go from ~300 ms in classification to around ~100ms. Note: this is only the cost of hte classification itself. This does not cover the cost to getChildren on all the nodes we walk. |
There was a problem hiding this comment.
"Overlaps" has very different semantics from "Intersects" from the perspective of the Editor and how they use that terminology. This is following the editor semantics for 'intersects', so i'd like to keep using that name.
|
👍 |
Scan less during classification.
4 participants
No description provided.