Skip to content

Adds 'did you mean' to the CLI args parser#35063

Merged
orta merged 4 commits intomicrosoft:masterfrom
orta:did_you_mean_cli
Nov 14, 2019
Merged

Adds 'did you mean' to the CLI args parser#35063
orta merged 4 commits intomicrosoft:masterfrom
orta:did_you_mean_cli

Conversation

@orta
Copy link
Copy Markdown
Contributor

@orta orta commented Nov 12, 2019

Catches some of the cases where casing or an "s" is missing in our config options:

node tsc.js index.js --allowJs  --declarations --sdsffs
error TS5025: Unknown compiler option '--declarations'. Did you mean 'declaration'?
error TS5023: Unknown compiler option '--sdsffs'.

@orta orta requested a review from sheetalkamat November 12, 2019 20:10
DanielRosenwasser
DanielRosenwasser reviewed Nov 12, 2019
View reviewed changes
sheetalkamat
sheetalkamat reviewed Nov 12, 2019
View reviewed changes
sheetalkamat
sheetalkamat reviewed Nov 13, 2019
View reviewed changes
sheetalkamat
sheetalkamat reviewed Nov 13, 2019
View reviewed changes
@orta orta force-pushed the did_you_mean_cli branch 2 times, most recently from 190f48b to 9a4ad52 Compare November 13, 2019 21:08
@orta
Copy link
Copy Markdown
Contributor Author

orta commented Nov 13, 2019 •
edited
Loading

OK, I'm now like 95% on my certainty that this is good 🍡 and correctly handles tsconfig values

Screen Shot 2019-11-13 at 4 00 09 PM

sheetalkamat
sheetalkamat reviewed Nov 13, 2019
View reviewed changes
sheetalkamat
sheetalkamat reviewed Nov 13, 2019
View reviewed changes
@orta orta merged commit ef0cca7 into microsoft:master Nov 14, 2019
@orta
Copy link
Copy Markdown
Contributor Author

orta commented Nov 14, 2019

Thanks!

@ark120202 ark120202 mentioned this pull request Nov 14, 2019
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orta @DanielRosenwasser @sheetalkamat