Add completion test for partial generic object#34559
Merged
andrewbranch merged 1 commit intomicrosoft:masterfrom Oct 18, 2019
Merged
Add completion test for partial generic object#34559andrewbranch merged 1 commit intomicrosoft:masterfrom
andrewbranch merged 1 commit intomicrosoft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed, that in https://github.com/microsoft/TypeScript/blob/master/tests/cases/fourslash/completionsWithOptionalPropertiesGeneric.ts the
hellois invalid, as it needs a: trueor: falsenext to it and points to a non-existing variable.In addition, the other completion tests introduced by #33937
all start with an empty object.
This is a small test to make sure, that we're also testing the "happy path" when there already is a valid property existing for the object that we're trying to auto-complete.