Does not add a duplicate completion when offering an export which was re-declared as a global#34524
Merged
orta merged 2 commits intomicrosoft:masterfrom Oct 17, 2019
Merged
Does not add a duplicate completion when offering an export which was re-declared as a global#34524orta merged 2 commits intomicrosoft:masterfrom
orta merged 2 commits intomicrosoft:masterfrom
Conversation
… re-declared as a global - fixes microsoft#32675
orta
commented
Oct 16, 2019
sheetalkamat
approved these changes
Oct 17, 2019
|
|
||
| /** | ||
| * Gathers symbols that can be imported from other files, deduplicating along the way. Symbols can be “duplicates” | ||
| * Gathers symbols that can be imported from other files, de-duplicating along the way. Symbols can be "duplicates" |
Contributor
Author
There was a problem hiding this comment.
Haha, I guess code-spell check doesn't have it
Member
There was a problem hiding this comment.
I make up a lot of words but this wasn’t one of them! 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32675
There are no duplication checks for exported completions, which is typically not a problem, but turns out to be an issue when you are taking a umd global and re-exporting it as a global internally.
Prior to my patch in completions.ts, this test would raise an error because of duplicate completions in the test. So the test verifies it doesn't crash and includes the assert.