Fix findAllRefs, getHighlightSpans, renameLocs, renameInfo for default exports and functions expressions#3367
Merged
Conversation
Member
Author
|
@mhegazy I know we discussed in the other issue that we wanted to move the |
Conflicts: src/compiler/checker.ts src/compiler/types.ts
Member
Author
Contributor
|
Can you added rename cases for function expression and class expression? // [|foo|] -> this should not get updated
function foo () {}
// [|foo|] -> Should this get update?
var x = function [|foo|] () {} // rename foo here should not affect foo outside
var y = function () {
[|foo|](); // Rename foo here
}// [|Foo|] -> this should not get updated
class Foo () {}
// [|Foo|] -> Should this get update
var x = class [|Foo|] () { \\ Rename Foo here
getClassName() {
[|Foo|] -> rename Foo here
}
}
var y = class {
getSomeName() {
[|Foo|]. -> rename Foo here
}
}Similar for findAllRefs |
Contributor
There was a problem hiding this comment.
What you mean by normalization? stripping quotes in getDeclaredName? if so could you mention this in the comment
This is a modified revert of 33693e8
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 29, 2015
Fix findAllRefs, getHighlightSpans, renameLocs, renameInfo for default exports and functions expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up from #3247, but merges into the
masterbranch.