Revert "Proposal: If there’s a package.json, only auto-import things in it"#32448
Merged
andrewbranch merged 1 commit intomicrosoft:masterfrom Jul 17, 2019
Conversation
…in it, more or less (microsoft#31893)" This reverts commit 60a1b1d.
Member
Author
This is failing in master too. |
andrewbranch
requested review from
DanielRosenwasser,
RyanCavanaugh,
sandersn,
uniqueiniquity and
weswigham
weswigham
approved these changes
Jul 17, 2019
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
I'll approve your revert, but y'all should see if you can fix the perf issue promptly and get it back in - hopefully it is just a lack of resolution caching, which should be fixable with some caching hosts that already exist within the compiler~
Member
Author
|
Thanks @weswigham, I really hope to—I’m leading with reverting because I’m just trying to stay afloat with DefinitelyTyped this week, and I didn’t want our beta release to have this regression in it. |
andrewbranch
deleted the
revert-31893-enhancement/only-import-from-package-json
branch
Member
|
@typescript-bot cherry-pick this to release-3.6 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jul 17, 2019
Component commits: f6cb90a Revert "Proposal: If there’s a package.json, only auto-import things in it, more or less (microsoft#31893)" This reverts commit 60a1b1d.
Collaborator
|
Hey @DanielRosenwasser, I've opened #32456 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31893
See #32441—this apparently needs some perf work for large projects 😬