Update DOM from TSJS-lib-generator - #32335
Conversation
1. Update Navigator and other small updates. 2. Make ProgressEvent generic. 3. Make `window: Window & typeof globalThis`. 4. Add types: * CSS Overflow * CSS Masking * Web Authentication * WebGL 2 The big change is that `window` now includes globals in its type via `typeof globalThis`. This helps some codebases a lot, such as chrome-devtools-frontend.
|
TypeScript Bot (@typescript-bot) user test this |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized community code test suite on this PR at 4a4298f. You can monitor the build here. It should now contribute to this PR's status checks. |
|
TypeScript Bot (@typescript-bot) test this |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the extended test suite on this PR at 4a4298f. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized Definitely Typed test suite on this PR at 4a4298f. You can monitor the build here. It should now contribute to this PR's status checks. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
User tests look good; no surprises there. Chrome-devtools-frontend especially benefits. |
|
From RWC:
window.navigate
~~~~~~~~
'navigate' not found on 'Window & typeof globalThis'. Did you mean 'navigator'?But it no longer has a related span "navigator is declared here", because navigator now has two declarations.
I don't think any of these breaks are bad. |
|
DT looks fine, just a couple of |
| /** | ||
| * Specifies the beginning and end of the document body. | ||
| /** | ||
| * Specifies the beginning and end of the document body. |
There was a problem hiding this comment.
👆 what is all this, LF/CRLF variation?
Looks set to create trouble down the line.
There was a problem hiding this comment.
Looks like comments.json (1) still has explicit \r\n and (2) something changed recently to stop converting them to \n.
The right fix is to explicitly change comments.json to use \n.
There was a problem hiding this comment.
Good idea!
People may have weird git configs, check in and then CRLF noise could obscure real changes for PR reviews.
3 participants
window: Window & typeof globalThis.The big change is that
windownow includes globals in its type viatypeof globalThis. This helps some codebases a lot, such as chrome-devtools-frontend.