Remove "Did you forget to use await" for unary arithmetic expressions#32334
Merged
andrewbranch merged 2 commits intomicrosoft:masterfrom Jul 10, 2019
Conversation
sandersn
reviewed
Jul 10, 2019
src/compiler/checker.ts
Outdated
| } | ||
|
|
||
| function checkArithmeticOperandType(operand: Node, type: Type, diagnostic: DiagnosticMessage): boolean { | ||
| function checkArithmeticOperandType(operand: Node, type: Type, diagnostic: DiagnosticMessage, tryAwait = false): boolean { |
Member
There was a problem hiding this comment.
I'm not sold on the parameter name. Seems more like 'suggestAwait' or something.
Member
Author
There was a problem hiding this comment.
Whether await is actually suggested is left up to some additional checks performed in the function; it could be trySuggestAwait or maybeSuggestAwait or isAwaitValid. I think the last sounds best. Thanks 👍
andrewbranch
deleted the
no-missing-await-on-unary-arithmetic-expressions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Um, so in #32239, one of the ones I added was
🤦♂
Did you forget to use 'await'? Did you really?