🤖 User test baselines have changed#32267
Closed
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Closed
🤖 User test baselines have changed#32267typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Member
|
cc @rbuckton you look over these changes form the generator types PR yet? |
Contributor
|
I reviewed them following an on-demand run, but I'm not certain how to proceed. Do I accept these changes as is, or do I need to submit issues against the user test repositories for errors? The majority of changes are due to outdated NodeJS definitions. |
Member
|
It's up to us - if updating these projects for their maintainers is too cumbersome, we can accept the baseline (which just means merging this PR), but that does lower how clean the baselines are and how easy it is to identify future change. Plus, at least for the rush-build projects the error blocks the build, which really hurts the test value :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh