Add opt-in behavior for custom transforms to support bundles#31301
Merged
Add opt-in behavior for custom transforms to support bundles#31301
Conversation
weswigham
reviewed
May 8, 2019
weswigham
approved these changes
May 8, 2019
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Good, but that union type looks like a typo 😉
rbuckton
force-pushed
the
fixCustomTransformers
branch
from
3fdf078 to
0c1a283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative approach to #29871, this PR addresses a backwards-compatibility issue when we added support for transforming
Bundlenodes. Custom transformers have the typeTransformerFactory<SourceFile>, as they only expect to receive source files. However, we assign them to an array ofTransformerFactory<Bundle | SourceFile>[]and may inadvertently pass aBundleto a transformer that is not able to support it.To address this, I've added an opt-in mechanism where custom transform authors can return a
CustomTransformerobject or the existingTransformer<SourceFile>callback. Custom transformers are then wrapped in a callback that invokes the transformation based on whether it is a function (and correctly wraps it in a call tochainBundle), or an object (in which case the appropriatetransformSourceFileortransformBundlemethods are called).Fixes #28310, #24459
Replaces #29871