👍

I would not expose the scanner. It is an implementation detail. We should be exposing this through our AST API.

-- Cyrus

From: Mohamed Hegazymailto:notifications@github.com
Sent: ‎5/‎4/‎2015 9:52 AM
To: Microsoft/TypeScriptmailto:TypeScript@noreply.github.com
Subject: [TypeScript] Fix #3012: expose scanner (#3020)

mhegazy wants to merge 1 commit into master from exposeScanner:

You can view, comment on, or merge this pull request online at:

#3020

Commit Summary

• Fix typescriptServices.d.ts in 1.5-beta is missing Scanner interface #3012: expose scanner

File Changes

• M src/compiler/scanner.tshttps://github.com/Fix #3012: expose scanner #3020/files#diff-0 (5)

Patch Links:

• https://github.com/Microsoft/TypeScript/pull/3020.patch
• https://github.com/Microsoft/TypeScript/pull/3020.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3020.

#3012 is for users like TSLint that need to walk through all nodes of a specific kind (like comment, whitespace etc.). I'm cool with exposing it somewhere, we've been using the scanner to do this work currently.