Improvements to generateTypes#28458
Merged
2 commits merged intoNov 12, 2018
Merged
Conversation
weswigham
approved these changes
Nov 10, 2018
amcasey
reviewed
Nov 10, 2018
amcasey
left a comment
amcasey
left a comment
Member
There was a problem hiding this comment.
Seems sensible to me but someone who understands prototypes should probably take a look.
| const name = node.left.name.text; | ||
| if (!isJsPrivate(name)) members.push(createProperty(/*decorators*/ undefined, /*modifiers*/ undefined, name, /*questionOrExclamationToken*/ undefined, anyType(), /*initializer*/ undefined)); | ||
| if (!isJsPrivate(name)) { | ||
| members.set(name, createProperty(/*decorators*/ undefined, /*modifiers*/ undefined, name, /*questionOrExclamationToken*/ undefined, anyType(), /*initializer*/ undefined)); |
Member
There was a problem hiding this comment.
Maybe skip the work if name is already present in members?
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.prototype, don't treat it as a namespace but as aconst. (Note we can still have a class merged with a namespace even though the class won't haveObject.prototype.)