Support getOccurrences on the TS Server#2666
Conversation
There was a problem hiding this comment.
looks like you are missing the actual handling of the command in onMessage
There was a problem hiding this comment.
Yup, just sent that part out. I'm not that familiar with the server so I'm still getting a feel for things.
|
Get occurences and get references share the same return type. It would be good if they shared a return type in protocol.d.ts also. |
|
You could make optional the lineText field in the ReferencesResponseItem and then use it for occurrences. |
|
On one hand, I agree that they are frankly similar and we'd be reusing code; on the other, I somewhat feel like we'd be conflating two concepts. Is |
There was a problem hiding this comment.
what does 'false' mean?
There was a problem hiding this comment.
if you are using destructuring i would put it everywhere in this method for consistency.
|
👍 |
Support getOccurrences on the TS Server
5 participants
No description provided.