Skip to content

Fixes #2601, incorrect resolution of this/super#2658

Merged
rbuckton merged 2 commits into
masterfrom
fixDecoratorBindingForSuperThis
Apr 8, 2015
Merged

Fixes #2601, incorrect resolution of this/super#2658
rbuckton merged 2 commits into
masterfrom
fixDecoratorBindingForSuperThis

Conversation

@rbuckton

@rbuckton rbuckton commented Apr 7, 2015

Copy link
Copy Markdown
Contributor

Updates to getThisContainer and getSuperContainer for proper container resolution of this and super in a decorator. Fixed a bug in checkSuperExpression when container is undefined.

@mhegazy

mhegazy commented Apr 7, 2015

Copy link
Copy Markdown
Contributor

unit tests?

@rbuckton

rbuckton commented Apr 8, 2015

Copy link
Copy Markdown
Contributor Author

Unit tests added.

@mhegazy

mhegazy commented Apr 8, 2015

Copy link
Copy Markdown
Contributor

👍

rbuckton added a commit that referenced this pull request Apr 8, 2015
@rbuckton rbuckton merged commit 68b38b3 into master Apr 8, 2015
@rbuckton rbuckton deleted the fixDecoratorBindingForSuperThis branch April 8, 2015 02:10
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants