Don't store @template constraint in a TypeParameterDeclaration node#26283
Don't store @template constraint in a TypeParameterDeclaration node#262833 commits merged intomasterfrom
Conversation
ghost
force-pushed
the
editTemplateConstraint
branch
from
8ca4412 to
e1aef1e
Compare
src/compiler/checker.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| function getEffectiveConstraintOfTypeParameter(node: TypeParameterDeclaration): TypeNode | undefined { |
There was a problem hiding this comment.
Can we have this function exposed as part of the public API to align with getEffectiveTypeParameterDeclarations?
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Needs one more test plus I agree that the new accessor should be public.
src/compiler/types.ts
Outdated
| kind: SyntaxKind.TypeParameter; | ||
| parent: DeclarationWithTypeParameterChildren | InferTypeNode; | ||
| name: Identifier; | ||
| // Note: Consider calling `getEffectiveConstraintOfTypeParameter` |
There was a problem hiding this comment.
Hm. We should have these notes as jsdoc for lots of things now. Something for a separate PR though.
|
|
||
| export interface JSDocTemplateTag extends JSDocTag { | ||
| kind: SyntaxKind.JSDocTemplateTag; | ||
| constraint: TypeNode | undefined; |
There was a problem hiding this comment.
Only the first type parameter in a list is constrained by the constraint. Can you add a test for that? That is, /** @template {number} T,U */ only constrains T.
There was a problem hiding this comment.
That was done in #24600 for the reason that reusing a node would be bad -- maybe not necessary now?
There was a problem hiding this comment.
The test jsdocTemplateTag3, added in #24600, will have fewer errors if this is changed, so it's already being tested.
There was a problem hiding this comment.
I don't like applying the constraint to multiple parameters even if there's no implementation reason that it's easier.
* origin/master: (283 commits) Don't error on destructure of private property with computed property syntax (microsoft#26360) getDefaultExportInfo: Use `getImmediateAliasedSymbol` instead of `getAliasedSymbol` (microsoft#26364) review comments restore old algorithm Dont use baseURL relative absolute paths in declaration emit, use absolute paths in bundle emit (microsoft#26341) Update user baselines (microsoft#26358) Don't store @template constraint in a TypeParameterDeclaration node (microsoft#26283) fixAddMissingMember: Support interface and don't crash on type parameter (microsoft#25995) Don't include class getter in spread type (microsoft#26287) Don't crash on computed property in destructure (microsoft#26334) Check the ambientness of a symbol name before attempting to trim it (microsoft#26312) Still generate signatures in SkipContextSensitive mode just to match on return types (microsoft#25937) fix handling if there is no commonPrefix Actually add sorting of elaboration text to user baselines Ping ryan instead of mohammed for user PRs now handle failed lookups make it work for root directory really, really fix test(?) add test fix commonPrefix handling ...
ghost
mentioned this pull request
ghost
mentioned this pull request
2 participants
A node needs to contain its children, but in
/** @template {number} T */,{number}was made a child ofTdespite not being contained in its range. Changed this so that{number}would be a child of the@templatenode which spans all the way to the end of the line.