Allow trailing commas after non-rest elements in destructuring#24672
Merged
mhegazy merged 1 commit intomicrosoft:masterfrom Jun 6, 2018
Merged
Allow trailing commas after non-rest elements in destructuring#24672mhegazy merged 1 commit intomicrosoft:masterfrom
mhegazy merged 1 commit intomicrosoft:masterfrom
Conversation
ghost
approved these changes
Jun 4, 2018
Contributor
|
thanks @bakkot! |
|
Will this be in 2.9.3 ? |
Contributor
|
No. TS 3.0, should be out next week. |
|
This problem still exists in the 3.0.1 |
|
@Andy-MS in React component import React, { PureComponent } from 'react';
export interface ButtonProps {
size?: 'large' | 'normal' | 'small';
}
export default class Button extends PureComponent<ButtonProps, {}> {
render() {
const {
size,
children,
...others, // error line
} = this.props;
return <a {...others}>{children}</a>;
}
} |
Contributor
Author
|
@JeromeLin, that's not syntactically valid JavaScript or (as of #22262) TypeScript. You can't have a trailing comma after a rest element ( TypeScript's behavior is correct; you should remove that comma. |
|
@bakkot thanks. this problem has been solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24628.
cc @Andy-MS for the original change in #22262.