--pretty by default in tsc.exe (the ChakraCore tsc host)#23754
Closed
DanielRosenwasser wants to merge 1 commit intomasterfrom
Closed
--pretty by default in tsc.exe (the ChakraCore tsc host)#23754DanielRosenwasser wants to merge 1 commit intomasterfrom
DanielRosenwasser wants to merge 1 commit intomasterfrom
Conversation
mhegazy
approved these changes
Apr 28, 2018
Collaborator
|
Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports
--prettyby default intsc.exegiven anticipated internal changes.Background
@kpreisser recommended fixing terminal escapes on #23408 (comment). Using the same logic to detect support for terminal escapes, we can determine whether we are outputting to a pseudoterminal device.
Within
tsc.js, we just need to look for the member which specifies as much.