annotateWithTypeFromJSDoc: Do less special-casing for arrow functions#22407
Conversation
ghost
requested review from
amcasey
approved these changes
Mar 8, 2018
| } | ||
| if (returnTypeNode && !decl.type) changes.insertTypeAnnotation(sourceFile, decl, returnTypeNode); | ||
| } | ||
| if (needParens) changes.insertNodeAfter(sourceFile, first(decl.parameters), createToken(SyntaxKind.CloseParenToken)); |
Member
There was a problem hiding this comment.
I think last might be clearer, even though they should return the same result.
src/services/textChanges.ts
Outdated
| const lparen = findChildOfKind(node, SyntaxKind.OpenParenToken, sourceFile)!.pos; | ||
| this.insertNodesAt(sourceFile, lparen, typeParameters, { prefix: "<", suffix: ">" }); | ||
| // If no `(`, is an arrow function `x => x`, so use the pos of the first parameter | ||
| const start = (findChildOfKind(node, SyntaxKind.OpenParenToken, sourceFile) || first(node.parameters)).pos; |
Member
There was a problem hiding this comment.
It might be interesting to add a test capturing the difference between full-start and start.
Author
There was a problem hiding this comment.
Looks like .getStart() works better. We are removing trivia (see annotateWithTypeFromJSDoc9.5.ts) but the type parameter is now flush with the open parenthesis instead of before the space.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #22404, ensures that we don't use
replaceNodeeven for arrow functions.