Closed
Conversation
mhegazy
reviewed
Feb 27, 2018
| }; | ||
| Logger.prototype.close = function () { | ||
| if (this.fd >= 0) { | ||
| fs.close(this.fd); |
Contributor
There was a problem hiding this comment.
why not just add an empty handler instead?
Author
There was a problem hiding this comment.
Because errors will be silently swallowed that way. I can of course do that but I do not feel like that is a good idea.
Contributor
There was a problem hiding this comment.
Because errors will be silently swallowed that way.
that was the intention anyways.. we are killing the server, we want to try to write to the log if we can, but if we fail, not sure we have much recourse here, the process is dying anyways.
mhegazy
added a commit
that referenced
this pull request
Mar 8, 2018
Contributor
|
closing in favor of #22405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to
fs.closeSyncoverfs.close, otherwise this will fail when used with Node.js 10.x.See nodejs/node#18668