Add a PatternMatcher API (similar to the one in Roslyn) for more advanced matching with features like NavigateTo.#2094
Conversation
…nced matching with features like NavigateTo.
There was a problem hiding this comment.
Comment with the character - older crowds call this a "pound". Crazy, I know. 😉
|
Looks good. Do we still plan to add additional parameters to the API call, such as an optional max results? In addition to the max results, we may want flags that can turn on or off match kinds. For example, a client may only want non-prefix matches when the searchValue is over a threshold length. |
|
@steveluc Hey Steve, #2084 tracks the work to limit the amount of data provided by NavigateTo. Could you explain a bit more what you mean by "For example, a client may only want non-prefix matches when the searchValue is over a threshold length." I'm not sure why you'd ever want to skip prefix-matches. Can you give an example? |
There was a problem hiding this comment.
When can candidate be undefined?
There was a problem hiding this comment.
candidate will also be falsy when it's the empty string
There was a problem hiding this comment.
Errr... I've never seen a loop shaped like this.
Conflicts: src/services/services.ts
Add a PatternMatcher API (similar to the one in Roslyn) for more advanced matching with features like NavigateTo.
5 participants
No description provided.