Skip to content

Of keyword classification#2086

Merged
JsonFreeman merged 5 commits into
masterfrom
ofKeywordClassification
Feb 20, 2015
Merged

Of keyword classification#2086
JsonFreeman merged 5 commits into
masterfrom
ofKeywordClassification

Conversation

@JsonFreeman

Copy link
Copy Markdown
Contributor

The 'of' keyword was not being classified because I forgot to change LastToken to point to OfKeyword.

@DanielRosenwasser

Copy link
Copy Markdown
Member

The API tests don't count as tests. 😉

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Lexical classifier test?

@DanielRosenwasser

Copy link
Copy Markdown
Member

Add another syntactic classifier test with a for-in/regular for loop.

@DanielRosenwasser

Copy link
Copy Markdown
Member

Great work! 👍 once the tests pass.

JsonFreeman added a commit that referenced this pull request Feb 20, 2015
@JsonFreeman JsonFreeman merged commit 791e913 into master Feb 20, 2015
@JsonFreeman JsonFreeman deleted the ofKeywordClassification branch February 20, 2015 20:29
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants