Hack to allow concat to work even when an Array isn't assignable to ReadonlyArray#20455
Hack to allow concat to work even when an Array isn't assignable to ReadonlyArray#204551 commit merged intomasterfrom
Conversation
|
Have you run this on RWC? |
|
Will do tomorrow. This makes the signature more lenient (assuming covariant arrays) so I wouldn't expect any new RWC failures. |
ghost
force-pushed
the
array_concat
branch
2 times, most recently
from
42ef827 to
5d5bbf0
Compare
|
There are some rwc failures on master, but I compared this branch to master and didn't see any differences. |
ghost
mentioned this pull request
|
@mhegazy @sandersn This PR appears to account for 50% of the slowdown we've seen in the checker between 2.6.2 and 2.7. It single-handedly slows down the check phase of compiling the compiler by about 7%. I haven't researched exactly why, but I suspect it has to do with us performing lots of structural comparisons of array types. The ideal way to fix this issue would be to have all the callback function types in |
|
@ahejlsberg has a possible fir to reorder the #21462, can you take a look. |
3 participants
Fixes #20268
Uses
T[] | ReadonlyArray<T>instead of justReadonlyArray<T>. There are probably a bunch of other places where we would need to do this to fix this error in general, but better to wait on #20454 for those instead.