Port20048 2.5#20083
Merged
RyanCavanaugh merged 5 commits intoNov 17, 2017
Merged
Conversation
billti
reviewed
Nov 17, 2017
| @@ -0,0 +1,7692 @@ | |||
| /*! ***************************************************************************** | |||
Member
Author
There was a problem hiding this comment.
Got inadvertently picked up during a branch switch; will remove
billti
reviewed
Nov 17, 2017
| getExecutingFilePath(): string { return void 0; }, | ||
| getCurrentDirectory(): string { return void 0; }, | ||
| getExecutingFilePath(): string { return ""; }, | ||
| getCurrentDirectory(): string { return ""; }, |
Member
Author
There was a problem hiding this comment.
Clarification: This is what it does in master
Member
There was a problem hiding this comment.
Right... but is it in any way related to the fixes happening here? If not, is there any reason to need this change also here?
Member
There was a problem hiding this comment.
Actually.... it's in the harness, not the product, so if the tests are passing I don't really care :-p
Member
Author
There was a problem hiding this comment.
We need this because we compute the default safe list location based on the current directory / current executing file path
billti
approved these changes
Nov 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #20048 (and its dependents) to release-2.5