Fix acquiring format options for getEditsForRefactor#18848
Merged
4 commits merged intomasterfrom Oct 2, 2017
Merged
Conversation
Member
|
Needs test |
ghost
mentioned this pull request
ghost
force-pushed
the
extractMethodFormat
branch
from
064609b to
52abafb
Compare
sheetalkamat
reviewed
Oct 2, 2017
| }); | ||
|
|
||
| describe("refactors", () => { | ||
| it("abcdefg", () => { |
Member
There was a problem hiding this comment.
Please describe the text here instead so its easy to figure out when test fails
sheetalkamat
approved these changes
Oct 2, 2017
| const response0 = session.executeCommand(command0).response; | ||
| assert.deepEqual(response0, /*expected*/ undefined); | ||
|
|
||
| const command: server.protocol.GetEditsForRefactorRequest = { |
Member
There was a problem hiding this comment.
Consider using executeCommandSeq instead so you don't need to write the type, sequence etc
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18328.
Thanks @sheetalkamat for the help spotting this fix.
Also removed
formatOptionsfromGetEditsForRefactorRequestArgssince that should be sent only once, not once per refactor. (This was added only recently so should be fine to remove before anyone uses it.)