TypedArrays: fixed find and findIndex callback param obj type.#18493
Merged
mhegazy merged 1 commit intomicrosoft:masterfrom Sep 18, 2017
Merged
TypedArrays: fixed find and findIndex callback param obj type.#18493mhegazy merged 1 commit intomicrosoft:masterfrom
mhegazy merged 1 commit intomicrosoft:masterfrom
Conversation
|
@NaridaL, |
mhegazy
reviewed
Sep 14, 2017
src/lib/es5.d.ts
Outdated
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number | undefined; |
mhegazy
reviewed
Sep 14, 2017
src/lib/es5.d.ts
Outdated
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number; |
mhegazy
reviewed
Sep 14, 2017
src/lib/es5.d.ts
Outdated
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number | undefined; |
mhegazy
reviewed
Sep 14, 2017
src/lib/es5.d.ts
Outdated
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number; |
Contributor
Author
|
Yeah... sorry about that. BTW, I tried it with the separate TypedArray interface, and it seems to be an improvement... previous: now: ... not sure if those statistics are the only relevant thing though. |
Contributor
Author
|
Oh yeah, the issues with U/Intarray should be fixed now, because it's not immediately obvious from the code reviews^^. |
Contributor
|
We should be moving them out of es5.d.ts anyways. #15780 should be in first though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18425.