Conversation
mhegazy
approved these changes
Sep 14, 2017
mhegazy
left a comment
mhegazy
left a comment
Contributor
There was a problem hiding this comment.
baselines for tests are missing
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18359
We already allow importing a '.js' file on
node_modules; this just extends that rule to anywhere.This also removes the diagnostic recommending to use
--allowJs, since it is now allowed to have a JS file even without--allowJs. The difference is that without--allowJswe won't compile the file.A potential downside of this change is that people who forget to add
--allowJswill notice that none of their JavaScript is being transpiled -- previously we would have specifically told them to set that option.