Skip to content

Handle undefined symbol.declarations in cloneSymbol #18474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 14, 2017
Merged

Handle undefined symbol.declarations in cloneSymbol #18474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ namespace ts {

function cloneSymbol(symbol: Symbol): Symbol {
const result = createSymbol(symbol.flags, symbol.escapedName);
result.declarations = symbol.declarations.slice(0);
result.declarations = symbol.declarations ? symbol.declarations.slice() : [];
result.parent = symbol.parent;
if (symbol.valueDeclaration) result.valueDeclaration = symbol.valueDeclaration;
if (symbol.constEnumOnlyModule) result.constEnumOnlyModule = true;
Expand Down
15 changes: 15 additions & 0 deletions tests/baselines/reference/mergedClassWithNamespacePrototype.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/b.ts(2,15): error TS2300: Duplicate identifier 'prototype'.


==== /a.d.ts (0 errors) ====
declare class Foo {}

==== /b.ts (1 errors) ====
declare namespace Foo {
namespace prototype {
~~~~~~~~~
!!! error TS2300: Duplicate identifier 'prototype'.
function f(): void;
}
}

14 changes: 14 additions & 0 deletions tests/baselines/reference/mergedClassWithNamespacePrototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//// [tests/cases/compiler/mergedClassWithNamespacePrototype.ts] ////

//// [a.d.ts]
declare class Foo {}

//// [b.ts]
declare namespace Foo {
namespace prototype {
function f(): void;
}
}


//// [b.js]
9 changes: 9 additions & 0 deletions tests/cases/compiler/mergedClassWithNamespacePrototype.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// @Filename: /a.d.ts
declare class Foo {}

// @Filename: /b.ts
declare namespace Foo {
namespace prototype {
function f(): void;
}
}