extractMethod: Don't try to extract an ExpressionStatement consisting of a single token#18450
Merged
3 commits merged intoSep 14, 2017
Merged
Conversation
… of a single token
ghost
requested a review
from 
amcasey
reviewed
Sep 13, 2017
| @@ -0,0 +1,9 @@ | |||
| /// <reference path='fourslash.ts' /> | |||
Member
There was a problem hiding this comment.
Alternatively, you could use a test like https://github.com/Microsoft/TypeScript/blob/2a70bf51589c4312a9329bce68cb2b5c9876e613/src/harness/unittests/extractMethods.ts#L394.
amcasey
approved these changes
Sep 13, 2017
amcasey
left a comment
amcasey
left a comment
Member
There was a problem hiding this comment.
While I disagree with our policy of preventing single-token extractions, I agree that this change is required for consistency.
RyanCavanaugh
approved these changes
Sep 13, 2017
mhegazy
approved these changes
Sep 14, 2017
Contributor
|
Please port this to release-2.5 as well. |
ghost
pushed a commit
that referenced
this pull request
Sep 14, 2017
… of a single token (#18450) * extractMethod: Don't try to extract an ExpressionStatement consisting of a single token * Move to unit test
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #18090. This problem comes up while typing; even when typing a document consisting of a single character, the editor recommends extracting it out to a function because it sees it as its own statement (because it is, so far).