Stop preventing extraction when a type parameter wouldn't bind correctly in a containing scope #18424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amcasey, |
|
@amcasey, |
...for shorthand property assignment names when collecting usages.
amcasey
force-pushed
the
ExtractTypeParameter
branch
from
e5eb1b0 to
80ec6fb
Compare
...correctly in a containing scope. It's not an issue because we'll just declare a corresponding type parameter on the extracted function and pass the original as a type argument. Fixes microsoft#18142
amcasey
force-pushed
the
ExtractTypeParameter
branch
from
80ec6fb to
255951c
Compare
RyanCavanaugh
approved these changes
Sep 13, 2017
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 16, 2017
Stop preventing extraction when a type parameter wouldn't bind correctly in a containing scope (cherry picked from commit 7b64229)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not an issue because we'll just declare a corresponding type parameter on the extracted function and pass the original as a type argument.
Fixes #18142
Note that the first commit is actually #18423