Skip to content

enclosingDeclaration can be undefined within getAccessibleSymbolChain #18400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 1 commit into from
Sep 12, 2017
Merged

enclosingDeclaration can be undefined within getAccessibleSymbolChain #18400

weswigham merged 1 commit into from
Sep 12, 2017

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Sep 12, 2017

Specifically, it is undefined when called via typeToString for diagnostics without a context parameter.

Fixes #18377, probably.

@weswigham weswigham requested review from a user and mhegazy September 12, 2017 01:05
@weswigham weswigham merged commit 403f585 into microsoft:master Sep 12, 2017
@weswigham
Copy link
Member Author

weswigham commented Sep 12, 2017

@mhegazy, does this need to be ported to 2.5?

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weswigham @mhegazy @msftclas