Finish applying no-object-literal-type-assertion lint rule#18218
Conversation
ghost
force-pushed
the
no-object-literal-type-assertion-2
branch
from
7553b3b to
8745182
Compare
ghost
force-pushed
the
no-object-literal-type-assertion-2
branch
from
d2b5e35 to
6ccb5e7
Compare
| projectName: req.projectName | ||
| }); | ||
| projectName: req.projectName, | ||
| // TODO: GH#18217 (property was not present) |
There was a problem hiding this comment.
I was just wondering if maybe it should be present. We never declared this property to be optional.
|
|
||
| // Provide global: true so plugins can detect why they can't find their config | ||
| this.projectService.logger.info(`Loading global plugin ${globalPluginName}`); | ||
| // tslint:disable-next-line no-object-literal-type-assertion (TODO: GH#18217) |
There was a problem hiding this comment.
looks like we should change the interface definition here instead.
There was a problem hiding this comment.
But the fact that the interface doesn't declare it would imply that we're not using the property?
| const result = parseJsonText(configFilename, configFileContent); | ||
| if (!result.endOfFileToken) { | ||
| // tslint:disable-next-line no-object-literal-type-assertion (TODO: GH#18217) | ||
| result.endOfFileToken = <EndOfFileToken>{ kind: SyntaxKind.EndOfFileToken }; |
There was a problem hiding this comment.
why do we do this in the first place.. @sheetalkamat any ideas?
| */ | ||
| export function readJsonConfigFile(fileName: string, readFile: (path: string) => string | undefined): JsonSourceFile { | ||
| const textOrDiagnostic = tryReadFile(fileName, readFile); | ||
| // tslint:disable-next-line no-object-literal-type-assertion (TODO:GH#18217) |
There was a problem hiding this comment.
we should change the return type for this function instead.
There was a problem hiding this comment.
To { parseDiagnostics: Diagnostic[] }? That exposes errors in its uses because we seem to assume we get the full source file.
There was a problem hiding this comment.
with optional members for fileName and extendedSourceFiles.. not sure if we need other things as well.
There was a problem hiding this comment.
that might end up touching many places though..
|
Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it. |
ghost
reopened this
ghost
force-pushed
the
no-object-literal-type-assertion-2
branch
from
6da37ac to
5d86382
Compare
ghost
force-pushed
the
no-object-literal-type-assertion-2
branch
from
5d86382 to
6de3bde
Compare
|
Some of these are OK but I feel like overall this is adding too many disables to look like a good fit |
6 participants
Continuation of #17278.
Applies the rule wherever possible and adds comments referencing #18217 at all fishy code.